Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix division by zero when prompt completion area is too small #9524

Merged
merged 2 commits into from
Feb 6, 2024
Merged

fix division by zero when prompt completion area is too small #9524

merged 2 commits into from
Feb 6, 2024

Conversation

diegostafa
Copy link
Contributor

@diegostafa diegostafa commented Feb 4, 2024 •
edited
Loading

fixes #9523

the-mikedavis
the-mikedavis requested changes Feb 6, 2024
View reviewed changes
helix-term/src/ui/prompt.rs Outdated Show resolved Hide resolved
@the-mikedavis the-mikedavis added C-bug Category: This is a bug A-helix-term Area: Helix term improvements S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 6, 2024
@the-mikedavis the-mikedavis changed the title fix division by zero in helix-term/src/ui/prompt.rs:404:34 fix division by zero when prompt completion area is too small Feb 6, 2024
@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 6, 2024
@archseer archseer merged commit a37af2d into helix-editor:master Feb 6, 2024
6 checks passed
cosmikwolf pushed a commit to cosmikwolf/helix that referenced this pull request Feb 26, 2024
@diegostafa @cosmikwolf
fix division by zero when prompt completion area is too small (helix-…
c84f3f9 
…editor#9524)
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@diegostafa @postsolar
fix division by zero when prompt completion area is too small (helix-…
5b96a61 
…editor#9524)
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
@diegostafa @mtoohey31
fix division by zero when prompt completion area is too small (helix-…
e0a058d 
…editor#9524)
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
@diegostafa @Vulpesx
fix division by zero when prompt completion area is too small (helix-…
15f9a5d 
…editor#9524)
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@diegostafa
fix division by zero when prompt completion area is too small (helix-…
84a5bda 
…editor#9524)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

attempt to divide by zero when resizing the terminal
3 participants
@diegostafa @the-mikedavis @archseer